FW: FW: miSprite Solution (?) Re: [ANNOUNCEMENT] Overlay and No DirectInput Test 4
Suhaib Siddiqi
ssiddiqi@inspirepharm.com
Thu Nov 9 05:00:00 GMT 2000
John,
someone suggested we need to call fbPictureInit. Maybe we need
to add this to xwin.
Suhaib
> -----Original Message-----
> From: Alan Hourihane [ mailto:ahourihane@valinux.com ]
> Sent: Thursday, November 09, 2000 8:04 AM
> To: devel@xfree86.org
> Subject: Re: FW: miSprite Solution (?) Re: [ANNOUNCEMENT]
> Overlay and No
> DirectInput Test 4
>
>
> You have to call fbPictureInit (or equivalent) in the driver.
> Check out
> the matrox driver for this function call to see where it's placed.
>
> Alan.
>
> On Thu, Nov 09, 2000 at 07:49:39AM -0500, Suhaib Siddiqi wrote:
> > Anyone has any comments on the following mail?
> >
> > Suhaib
> >
> >
> --------------------------------------------------------------
> --------------
> > ------------------
> > Suhaib and Harold,
> >
> > I tracked down the 'bug' for the misprite problems.
> >
> > in
> > miSpriteInitialize there is the following:
> >
> > #ifdef RENDER
> > PictureScreenPtr ps = GetPictureScreen(pScreen);
> > #endif
> >
> > where GetPictureScreen is defined as:
> >
> > #define GetPictureScreen(s)
> >
> ((PictureScreenPtr)((s)->devPrivates[PictureScreenPrivateIndex].ptr))
> >
> > ^
> > I believe the problem is
> > here-----------------------------------------------^
> >
> > PictureScreenPrivateIndex is never defined.
> >
> > The place it is initialized is in render/picture.c:PictureInit().
> > PictureScreenPrivateIndex = AllocateScreenPrivateIndex();
> >
> > This is called by mipict.c:miPictureInit()
> > miPictureInit() is never used anywhere.
> >
> > So when 'ps = GetPictureScreen(pScreen);' is called, ps points to
> > garbage.
> >
> > However, if we undef RENDER, all the problems go away.
> >
> > So, do we undef RENDER? What is its purpose... Or notify
> someone that
> > the render function are broken.
> >
> > John
> >
>
More information about the Cygwin-xfree
mailing list