Bizarre server crash

[Alexander Gottwald]

Brian Gallew wrote:

> Alexander Gottwald said:
> > I noticed this too. Happens with all apps (I've found) which change
> > resolution.
> 
> The interesting thing is that it clearly isn't *all* apps that change
> resolution.  I can run Neverwinter Nights (and often do!) concurrently
> with XFree86 with nary a problem.  This may well be a legacy DirectX
> thing, though (DiabloII is quite a bit older, after all).

seems to depend on the colordepth change.

Hope this patch fixes it (can't test. The computer where i saw the crash
is at work.)

bye
    ago
-- 
 Alexander.Gottwald@informatik.tu-chemnitz.de 
 http://www.gotti.org           ICQ: 126018723
-------------- next part --------------
Index: winshadddnl.c
===================================================================
RCS file: /cvs/xc/programs/Xserver/hw/xwin/winshadddnl.c,v
retrieving revision 1.23
diff -u -r1.23 winshadddnl.c
--- winshadddnl.c	2002/10/17 08:18:25	1.23
+++ winshadddnl.c	2003/01/25 14:43:45
@@ -123,18 +123,17 @@
 
   ErrorF ("winReleasePrimarySurfaceShadowDDNL - Hello\n");
 
-  /*
-   * Detach the clipper from the primary surface.
-   * NOTE: We do this explicity for clarity.  The Clipper is not released.
-   */
-  IDirectDrawSurface4_SetClipper (pScreenPriv->pddsPrimary4,
-				  NULL);
-  
-  ErrorF ("winReleasePrimarySurfaceShadowDDNL - Detached clipper\n");
-
-  /* Release the primary surface, if there is one */
   if (pScreenPriv->pddsPrimary4)
     {
+      /*
+       * Detach the clipper from the primary surface.
+       * NOTE: We do this explicity for clarity.  The Clipper is not released.
+       */
+      IDirectDrawSurface4_SetClipper (pScreenPriv->pddsPrimary4,
+	 	  NULL);
+      ErrorF ("winReleasePrimarySurfaceShadowDDNL - Detached clipper\n");
+
+      /* Release the primary surface, if there is one */
       IDirectDrawSurface4_Release (pScreenPriv->pddsPrimary4);
       pScreenPriv->pddsPrimary4 = NULL;
     }