Few minor issues

[Harold L Hunt II]

Biju wrote:
> I dont know whether others noticed these. 
> 
> 1)
> After we start XWin.exe the mouse pointer will automatically move to center of screen.
> This is OK for normal mode, -nodecoration and -fullscreen. 
> But I think its not needed in -multiwindow and -rootless modes.
> 

I looked for the code that does this (it is general X code, not 
Cygwin/XFree86-specific code) the last time that someone brought this up 
(wasn't it you?).  I could not find the code and I won't be looking for 
it again.  Someone else can do the searching of the source code tree 
under xc/programs/Xserver to try to find it.  It is most likely in 
xc/programs/Xserver/hw/os or xc/programs/Xserver/hw/dix, but I couldn't 
find it in either of those directories.

> 2) 
> On -multiwindow mode if we press Alt-F4 on any of the X application screen 
> it will popup "Exit Dialog Box" for XWin.exe.
> 

I don't know if there is a better way that this should work.  Maybe you 
have a point.  I might try to see if I can do anything.

> 3)
> On normal mode if click "close (X)" button on title bar, or "close" on sysmenu
> It close XWin.exe with out showing "Exit Dialog Box" 
> 

Now you have a point.  I was just calling GiveUp () in the WM_CLOSE 
message.  I moved the call to GiveUp () to a WM_GIVEUP message. 
WM_CLOSE now opens the dialog box.  The dialog box sends WM_GIVEUP if OK 
is pressed.  This seems to work well on my system.

> Can we centralize the "Exit Dialog Box" using DS_CENTER flag for STYLE attribute?
> 

Thanks.  I never saw any window styles for centering.  There doesn't 
seem to be much documentation on the DS_* flags as a search in MSDN only 
turns up a handful of articles.  I applied this to my local XWin.rc.

> To hide from taskbar we may be able to use WS_EX_TOOLWINDOW flag for EXSTYLE attribute.
> I am attaching an example for this.
> 

Hiding from the taskbar?  It isn't shown on my taskbar.  I am using 
Windows XP... what version are you using?

WS_EX_TOOLWINDOW doesn't seem right.  I tried it... it creats a window 
that looks like a tool pallette in Photoshop, not a dialog box.

I did, however, add the extended style WS_EX_DLGMODALFRAME and the 
normal style WS_DLGFRAME.  These didn't change anything for me, but they 
may help for you.

I also noticed that an already existing exit dialog was not being 
brought to the foreground when the user performed another action that 
would display the dialog.  The result was that the dialog box seemed to 
be lost and it seemed that you couldn't exit Cygwin/XFree86.  I changed 
this to call SetForegroundWindow () for the dialog box when it already 
exists.  This brings it to the top in response to such user-generated 
events.

Any ideas on how to get rid of the Maximize button on the dialog?  I can 
do it by removing the WS_SYSMENU style... should we be using WS_SYSMENU 
or not?  Not using WS_SYSMENU cause our icon to not be displayed on the 
upper-left hand corner, but I can't seem to find a flag that says "no 
maximize button".

Thanks for your help,

Harold